paul/dojo-mars-rover
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

R: Rover.constructor use copy() on state

Browse source
This commit is contained in:
Paul Hameteman 2025-10-14 23:02:00 +02:00
commit eb63607e53
2 changed files with 8 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

4
TECHDEBT.md
View file

@ -11,8 +11,8 @@
- [ ] Rover.turnLeft use copy() on state - [ ] Rover.turnLeft use copy() on state
- [ ] Rover.turnRight use copy() on state - [ ] Rover.turnRight use copy() on state
- [ ] Rover.move use copy() on state - [ ] Rover.move use copy() on state
- [ ] Rover.constructor use copy() on state - [x] Rover.constructor use copy() on state
- [ ] Change RoverState to Data Class - [x] Change RoverState to Data Class
# RPP # RPP
- [ ] Refine Abstractions - [ ] Refine Abstractions

9
src/main/kotlin/org/example/Rover.kt
View file

@ -4,9 +4,12 @@ class Rover {
constructor(commands: String) { constructor(commands: String) {
val command = commands.split(' ') val command = commands.split(' ')
if (command.size >= ROVER_MINIMUM_NEEDED_COMMANDS) { if (command.size >= ROVER_MINIMUM_NEEDED_COMMANDS) {
state.positionX = command[ROVER_STARTING_POSITION_X].toInt() state =
state.positionY = command[ROVER_STARTING_POSITION_Y].toInt() state.copy(
state.heading = Heading.from(command[ROVER_FACING_DIRECTION][ROVER_COMMANDLIST_DIRECTION]) ?: Heading.NORTH positionX = command[ROVER_STARTING_POSITION_X].toInt(),
positionY = command[ROVER_STARTING_POSITION_Y].toInt(),
heading = Heading.from(command[ROVER_FACING_DIRECTION][ROVER_COMMANDLIST_DIRECTION]) ?: state.heading,
)
} }
} }